ESS 5.1.19 & Emacs 21.1.3

[Rich Heiberger]

This is addressed by the patch proposed by Stephen Eglen.  I believe it
has already been committed to the next release of ESS.  I confirmed that it
solves the problem using ntemacs 21.1 on windows.

Rich
-------
Date: Mon, 15 Oct 2001 14:36:12 -0500 (CDT)
From: Stephen Eglen <eglen at pcg.wustl.edu>
To: ess-bugs at stat.math.ethz.ch
Subject: ess-mode 5.1.19; concat defun no longer accepts integers
Sender: owner-ess-core at stat.math.ethz.ch
Precedence: bulk



Emacs  : GNU Emacs 21.0.106.1
Package: ess-mode 5.1.19

Hi,

In Emacs 21 prereleases, the concat defun no longer accepts integers.
This messes up ess-execute-objects and ess-execute-attach.

Emacs 21 NEWS:
** `concat' no longer accepts individual integer arguments,
as promised long ago.

A Similar entry is in XEmacs 21 news:
** The `concat' function no longer accepts integer arguments.

A similar problem is on line 1428 of ess-inf.el.  Here is a suggested
patch.  (You could use int-to-string, but on Emacs, that is just an
alias anyway for number-to-string.)


*** /tmp/ess-inf.el~    Mon Oct 15 14:35:31 2001
--- /tmp/ess-inf.el     Mon Oct 15 14:35:31 2001
***************
*** 1377,1383 ****
        (invert (< num-arg 0))
        (the-command (format inferior-ess-objects-command the-posn ".*"))
        (the-message (concat ">>> Position "
!                            the-posn
                             " ("
                             (nth (1- the-posn) (ess-search-list))
                             ")\n")))
--- 1377,1383 ----
        (invert (< num-arg 0))
        (the-command (format inferior-ess-objects-command the-posn ".*"))
        (the-message (concat ">>> Position "
!                            (number-to-string the-posn)
                             " ("
                             (nth (1- the-posn) (ess-search-list))
                             ")\n")))
***************
*** 1425,1431 ****
    (ess-execute (concat "attach(\""
                     (directory-file-name (expand-file-name dir))
                     "\""
!                    (if posn (concat "," (prefix-numeric-value posn)))
                     ")") 'buffer)
    (setq ess-sp-change t))
  
--- 1425,1432 ----
    (ess-execute (concat "attach(\""
                     (directory-file-name (expand-file-name dir))
                     "\""
!                    (if posn (concat "," (number-to-string
!                                          (prefix-numeric-value posn))))
                     ")") 'buffer)
    (setq ess-sp-change t))
  





current state:
==============
(setq
 ess-language "S"
 ess-dialect "R"
 ess-ask-for-ess-directory nil
 ess-ask-about-transfile nil
 ess-directory nil
 ess-keep-dump-files "always"
 ess-source-directory "/tmp/"
 )
...
-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
ess-help mailing list -- To (un)subscribe, send
subscribe	or	unsubscribe
(in the "body", not the subject !)  To: ess-help-request at stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._