[Rd] bug fix Re: Matrix does not build with R trunk since Oct.

[Hin-Tak Leung]

Here is what make Matrix builds. I guess this means a new Matrix 1.0-12 will be released. r57849 is dec 2011, and in any case, a conditional based on precise svn version seems a bad idea. I haven't pinned point why it broke in Oct 2012, probably co-incide with the switch of R_SVN_VERSION's data type in around that time. Just grep'ed for ".M.classEnv" to see where it comes from.

--- Matrix/NAMESPACE~	2013-01-30 11:14:48.000000000 +0000
+++ Matrix/NAMESPACE	2013-02-19 18:50:19.372867331 +0000
@@ -75,7 +75,7 @@
 #        "writeHB",
        , "writeMM"
        )
-if(getRversion() < "2.15.0" || R.version$`svn rev` < 57849)
+if(getRversion() < "2.15.0")
     export(".M.classEnv")
 
 ## substitute for using  cbind() / rbind()


--- On Fri, 15/2/13, Hin-Tak Leung <htl10 at users.sourceforge.net> wrote:

> FWIW, extracting snapshot source
> elsewhere outside svn, run "tools/rsync-recommended" then
> just plain "./configure && make" doesn't work
> either. Nothing to do with building inside checkout nor
> extra configure options.
> 
> This is fedora 18, x86_64.
> 
> --- On Fri, 15/2/13, Hin-Tak Leung <htl10 at users.sourceforge.net>
> wrote:
> 
> > Somebody else had written separately about this before,
> and
> > so have I a couple of months ago. I assumed this will
> be
> > fixed before the next R. Since R 3.0 is supposedly only
> 6
> > weeks away, even if it is fixed now it doesn't leave
> much
> > room for testing. 
> > 
> > Anyway neither Matrix 1.0-11 (current) nor 1.0-9 (sept
> 2012)
> > build with current R trunk.  The  last time it did
> > was 1. 0-9 on 3rd october over 4 months ago. So it
> appears
> > to be due to change inside r trunk in sept or early
> oct. 
> > 
> > 
> > ----------------
> > Loading required package: Matrix
> > Error in namespaceExport(ns, exports) : undefined
> exports:
> > .M.classEnv
> > Error : require(Matrix) is not TRUE
> > ERROR: installing package indices failed
> > * removing ‘/svn-loc/R/library/Matrix’
> > * restoring previous ‘/svn-loc/R/library/Matrix’
> > make[2]: *** [Matrix.ts] Error 1
> > make[2]: Leaving directory
> > `/svn-loc/R/src/library/Recommended'
> > make[1]: *** [recommended-packages] Error 2
> > make[1]: Leaving directory
> > `/svn-loc/R/src/library/Recommended'
> > make: *** [stamp-recommended] Error 2
> > ----------------
> > 
> > If it matters, here is what r trunk built with:
> >  ./configure --enable-memory-profiling
> > --enable-strict-barrier
> --enable-byte-compiled-packages
> > --with-valgrind-instrumentation=2 --enable-lto
> > 
> > 
> >
>