[ESS] make problems with latest git

[Ross Boylan]

On Mon, Mar 05, 2018 at 10:36:46AM -0800, Ross Boylan wrote:
> 
> BTW, make in a regular BASH shell produced lots of warnings and at
> least  one error, which seems to have come at the end (or maybe caused
> the end?):
> [ess-sas-d:] require 'ess-sas-l ...
> Source file `/home/ross/ESS/lisp/ess-sas-a.el' newer than
> byte-compiled file
> Symbol's value as variable is void: sas-program
> Makefile:115: recipe for target 'ess-sas-d.elc' failed
> make[1]: *** [ess-sas-d.elc] Error 255
> make[1]: Leaving directory '/home/ross/ESS/lisp'
> Makefile:10: recipe for target 'all' failed
> make: *** [all] Error 2
> 

This is a show-stopper for me; ESS won't load in emacs.  I tried
switching to the v17.11 tag, but it behaves the same way.

Ross

When I start emacs with --debug-init, here's the trace (v17.11):
Debugger entered--Lisp error: (void-variable sas-program)
eval(sas-program)
byte-code("\303^H\304N\211^Y\203^N^@  @\202^O^@\n)!\207" [symbol sv exp eval saved-value] 4)
custom-initialize-reset(ess-sas-submit-command sas-program)
  custom-declare-variable(ess-sas-submit-command sas-program "*Command to invoke SAS in batch; buffer-local." :group ess-sas :type string)
    byte-code("\300\301\302\303\304\305\306\307&^G\210\300\310\311\312\304\305\306\307&^G\210\300\313\314\315\304\305\306\307&^G\210\300\316\302\317\304\305\306\307&^G\210\320\316!\210\300\321\322\323\304\305\306\307&^G\210\300\324\302\325\304\305\306\307&^G\210\320\324!\210\300\326\327\330\304\305\306\307&^G\210\300\331\332\333\304\305\306\$
require(ess-sas-a)
byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\207" [require ess ess-mode ess-custom ess-sas-a] 2)
require(ess-sas-l)
byte-code("\301\302!\210\303\304!\210\303\305!\210\303\306!\210\301\307!\210\303\310!\210\301\311!\210\312\313\314^H\315$\210\312\316\317^H\315$\210\312\320\314^H\321$\207" [no-doc ess-message "[ess-sas-d:] require 'comint & 'shell ..." require comint shell executable "[ess-sas-d:] require 'ess-sas-l ..." ess-sas-l "[ess-sas-d:] (autoloa$
require(ess-sas-d)
apply(require ess-sas-d nil)
  ess-require(ess-sas-d)
    byte-code("\305\306!\210\307\310^H\"\204 ^@\311\312   \"\211^Z^H\235\203^[^@^H\210\202^_^@\n^HB^P)\305\313!\210\305\314!\210\305\315!\210\305\316!\210^K\203;^@\305\317!\210\202?^@\305\320!\210\305\321!\210\305\322!\210\305\323!\210\305\324!\210\325\326\327\f\"!\210\305\330!\210\305\331!\210\325\326\332\f\"!\210\305\333!\210\305\334!\210\$
load("ess-site")
eval-buffer(#<buffer  *load*> nil "/home/ross/.emacs" nil t)  ; Reading at buffer position 316
load-with-code-conversion("/home/ross/.emacs" "/home/ross/.emacs" t t)
load("~/.emacs" t t)
#[0 "^H\205\262^@     \306=\203^Q^@\307^H\310Q\202;^@ \311=\204^^^@\307^H\312Q\202;^@\313\307\314\315#\203*^@\316\202;^@\313\307\314\317#\203:^@\320\nB^R\321\202;^@\316\322^S\323^A\322\211#\210^K\322=\203a^@\324\325\326\307^H\327Q!\"\323^A\322\211#\210^K\322=\203`^@^A^S\210^K\203\243^@\330^K!\331\232\203\243^@\332^K!\211\333P\334^A!\203}$
command-line()
normal-top-level()

Or with current head (c1a308e5de3e555a3e9764140671899c381391dc):
Debugger entered--Lisp error: (void-variable sas-program)
  eval(sas-program)
  byte-code("\303^H\304N\211^Y\203^N^@  @\202^O^@\n)!\207" [symbol sv exp eval saved-value] 4)
  custom-initialize-reset(ess-sas-submit-command sas-program)
  custom-declare-variable(ess-sas-submit-command sas-program "*Command to invoke SAS in batch; buffer-local." :group ess-sas :type string)
  byte-code("\300\301\302\303\304\305\306\307&^G\210\300\310\311\312\304\305\306\307&^G\210\300\313\314\315\304\305\306\307&^G\210\300\316\302\317\304\305\306\307&^G\210\320\316!\210\300\321\322\323\304\305\306\307&^G\210\300\324\302\325\304\305\306\307&^G\210\320\324!\210\300\326\327\330\304\305\306\307&^G\210\300\331\332\333\304\305\306\$
  require(ess-sas-a)
  byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\207" [require ess ess-mode ess-custom ess-sas-a] 2)
  require(ess-sas-l)
  byte-code("\301\302!\210\303\304!\210\303\305!\210\303\306!\210\301\307!\210\303\310!\210\301\311!\210\312\313\314^H\315$\210\312\316\317^H\315$\210\312\320\314^H\321$\207" [no-doc ess-message "[ess-sas-d:] require 'comint & 'shell ..." require comint shell executable "[ess-sas-d:] require 'ess-sas-l ..." ess-sas-l "[ess-sas-d:] (autoloa$
  require(ess-sas-d)
  apply(require ess-sas-d nil)
  ess-require(ess-sas-d)
  byte-code("\305\306!\210\307\310^H\"\204 ^@\311\312   \"\211^Z^H\235\203^[^@^H\210\202^_^@\n^HB^P)\305\313!\210\305\314!\210\305\315!\210\305\316!\210^K\203;^@\305\317!\210\202?^@\305\320!\210\305\321!\210\305\322!\210\305\323!\210\305\324!\210\325\326\327\f\"!\210\305\330!\210\305\331!\210\325\326\332\f\"!\210\305\333!\210\305\334!\210\$
  load("ess-site")
  eval-buffer(#<buffer  *load*> nil "/home/ross/.emacs" nil t)  ; Reading at buffer position 316
  load-with-code-conversion("/home/ross/.emacs" "/home/ross/.emacs" t t)
  load("~/.emacs" t t)
  #[0 "^H\205\262^@     \306=\203^Q^@\307^H\310Q\202;^@ \311=\204^^^@\307^H\312Q\202;^@\313\307\314\315#\203*^@\316\202;^@\313\307\314\317#\203:^@\320\nB^R\321\202;^@\316\322^S\323^A\322\211#\210^K\322=\203a^@\324\325\326\307^H\327Q!\"\323^A\322\211#\210^K\322=\203`^@^A^S\210^K\203\243^@\330^K!\331\232\203\243^@\332^K!\211\333P\334^A!\203}$
  command-line()
  normal-top-level()

Which is odd, since the code immediately before the declaration of ess-sas-submit-command seems to define sas-program

Also tried (at head) changing the code to
(defcustom ess-sas-submit-command "sas"
but still got errors.