[ESS] insert new lines in roxygen documentation

[Lionel Henry]

In my emacs -Q, RET is bound to 'newline-and-indent but in yours it's
bound to 'newline. So I guess we need to also substitute 'newline to
account for variation in default Emacs setups.

Hmm... Actually we shouldn't need any key substitution at all. I just
noticed that ess-mode binds C-m (that is, RET) to 'newline-and-indent,
which is why your global keybinding is not the same as the one in R
buffers. So I will change that ESS mode binding to
'ess-newline-and-indent, remove the key substitutions, and it will
work in all cases.

In the meantime you can bind it manually to 'ess-newline-and-indent in
your personal configuration.

Thanks for the report.

Lionel



> On 17 déc. 2015, at 12:37, Andreas Leha <andreas.leha using med.uni-goettingen.de> wrote:
> 
> Sorry, I might have misunderstood you.  That *was* in an R buffer.
> 
> In the scratch buffer I get
> 
> ,----
> | RET (translated from <return>) runs the command newline (found in
> | global-map), which is an interactive compiled Lisp function in
> | ‘simple.el’.
> | 
> | It is bound to RET.
> | 
> | (newline &optional ARG INTERACTIVE)
> `----
> 
> Running `ess-newline-and-indent' directly works as expected.
> 
> Regards,
> Andreas
> 
> 
> 
> Lionel Henry <lionel.hry using gmail.com> writes:
>> And in an R buffer? It should normally be 'ess-indent-and-newline.
>> 
>> What happens when you call (ess-indent-and-newline) in a roxy block?
>> 
>> 
>>> On 17 déc. 2015, at 12:19, Andreas Leha <andreas.leha using med.uni-goettingen.de> wrote:
>>> 
>>> Hi Lionel,
>>> 
>>> Thanks for following that up.
>>> 
>>> I tried with emacs -Q [fn:1] and get the same result, so I guess it's
>>> not my configuration...
>>> 
>>> Here is my keybinding for RET:
>>> 
>>> ,----
>>> | RET (translated from <return>) runs the command newline-and-indent,
>>> | which is an interactive compiled Lisp function in ‘simple.el’.
>>> | 
>>> | It is bound to RET.
>>> | 
>>> | (newline-and-indent)
>>> `----
>>> 
>>> Thanks,
>>> Andreas
>>> 
>>> [fn:1] Using this .emacs:
>>> 
>>> --8<---------------cut here---------------start------------->8---
>>> ; ess
>>> (add-to-list 'load-path "~/local/emacs/ess/lisp")
>>> (require 'ess-site)
>>> --8<---------------cut here---------------end--------------->8---
>>> 
>>> 
>>> 
>>> Lionel Henry <lionel.hry using gmail.com> writes:
>>>> Hello,
>>>> 
>>>> We are trying to move away from advising core Emacs functions. So we
>>>> now substitute key definitions from the global environment.
>>>> 
>>>> It should work if you have 'newline-and-indent bound to RET in your
>>>> global keymap. Can you tell us what function is globally bound to RET
>>>> in your Emacs?
>>>> 
>>>> Lionel
>>>> 
>>>> 
>>>>> On 17 déc. 2015, at 11:56, Andreas Leha <andreas.leha using med.uni-goettingen.de> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> I just upgraded ess
>>>>> (to version 15.09-2 [git: 680549abaaa3750de090c47049c392adcb25aaaa]).
>>>>> 
>>>>> Inserting a newline (via RET) when inside roxygen block does not add the
>>>>> roxy prefix (##') automatically anymore.  I have
>>>>> `ess-roxy-insert-prefix-on-newline' set to t (the default).
>>>>> 
>>>>> Am I missing something?
>>>>> 
>>>>> M-j works and does insert the ##' for me.  But will take some time to
>>>>> get used to.
>>>>> 
>>>>> Thanks,
>>>>> Andreas
>>>>> 
>>>>> PS: this is on os x and
>>>>> GNU Emacs 25.1.50.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1134)) of 2015-11-21
>>>>> 
>>>>> ______________________________________________
>>>>> ESS-help using r-project.org mailing list
>>>>> https://stat.ethz.ch/mailman/listinfo/ess-help
>>>> 
>>>> ______________________________________________
>>>> ESS-help using r-project.org mailing list
>>>> https://stat.ethz.ch/mailman/listinfo/ess-help
>>> 
>>> ______________________________________________
>>> ESS-help using r-project.org mailing list
>>> https://stat.ethz.ch/mailman/listinfo/ess-help
>> 
>> ______________________________________________
>> ESS-help using r-project.org mailing list
>> https://stat.ethz.ch/mailman/listinfo/ess-help
> 
> ______________________________________________
> ESS-help using r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/ess-help