[ESS] ess patch: avoid (error "Invalid buffer")

[Vitalie Spinu]

Hi Sam, 

Thanks for the catch, it's applied now.

Best, 
Vitalie.

>>>> Sam Steingold <sds at gnu.org>
>>>> on Mon, 27 Feb 2012 11:23:06 -0500 wrote:

  > The following message is a courtesy copy of an article
  > that has been posted to gmane.emacs.ess.general as well.

  > when ess-help-kill-bogus-buffers is set to t, I get this error:

  > Debugger entered--Lisp error: (error "Invalid buffer")
  >   signal(error ("Invalid buffer"))
  >   error("Invalid buffer")
  >   display-buffer(#<killed buffer>)
  >   ess-display-temp-buffer(#<killed buffer>)
  >   ess--switch-to-help-buffer(#<killed buffer>)
  >   ess-display-help-on-object(#("zz" 0 2 (fontified t)))
  >   inferior-R-input-sender(#<process R> #("?zz" 0 3 (fontified t)))
  >   comint-send-input()
  >   inferior-ess-send-input()
  >   call-interactively(inferior-ess-send-input nil nil)

  > this patch avoids it:

  >      * ess-help.el (ess-display-help-on-object): do not try to display a
  >        dead buffer.

  > Index: ess-help.el
  > ===================================================================
  > --- ess-help.el	(revision 4584)
  > +++ ess-help.el	(working copy)
  > @@ -250,9 +250,8 @@ an inferior emacs buffer) the GUI help w
  >                ;;dbg (ess-write-to-dribble-buffer
  >                ;;dbg	 (format "(ess-help '%s' before switch-to..\n" hb-name)
  >                (set-buffer-modified-p 'nil)
  > -              (toggle-read-only t)))))
  > -      (ess--switch-to-help-buffer tbuffer)
  > -      )))
  > +              (toggle-read-only t)
  > +              (ess--switch-to-help-buffer tbuffer))))))))

  >  (defun ess-display-help-in-browser ()